Greg Kroah-Hartman
598cf27219
Link: https://lore.kernel.org/r/20260217200002.683975158@linuxfoundation.org Tested-by: Florian Fainelli <florian.fainelli@broadcom.com> Tested-by: Takeshi Ogasawara <takeshi.ogasawara@futuring-girl.com> Tested-by: Peter Schneider <pschneider1968@googlemail.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Salvatore Bonaccorso <carnil@debian.org> Tested-by: Brett A C Sheffield <bacs@librecast.net> Tested-by: Mark Brown <broonie@kernel.org> Tested-by: Luna Jernberg <droidbittin@gmail.com> Tested-by: Ronald Warsow <rwarsow@gmx.de> Tested-by: Justin M. Forbes <jforbes@fedoraproject.org> Tested-by: Ron Economos <re@w6rz.net> Tested-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
86 lines
1.7 KiB
Plaintext
86 lines
1.7 KiB
Plaintext
// SPDX-License-Identifier: GPL-2.0-only
|
|
///
|
|
/// Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0
|
|
///
|
|
// Copyright: (C) 2015 Intel Corp.
|
|
// Options: --no-includes --include-headers
|
|
//
|
|
// Keywords: dma_pool_zalloc, pci_pool_zalloc
|
|
//
|
|
|
|
virtual context
|
|
virtual patch
|
|
virtual org
|
|
virtual report
|
|
|
|
//----------------------------------------------------------
|
|
// For context mode
|
|
//----------------------------------------------------------
|
|
|
|
@depends on context@
|
|
expression x;
|
|
statement S;
|
|
@@
|
|
|
|
* x = \(dma_pool_alloc\|pci_pool_alloc\)(...);
|
|
if ((x==NULL) || ...) S
|
|
* memset(x,0, ...);
|
|
|
|
//----------------------------------------------------------
|
|
// For patch mode
|
|
//----------------------------------------------------------
|
|
|
|
@depends on patch@
|
|
expression x;
|
|
expression a,b,c;
|
|
statement S;
|
|
@@
|
|
|
|
- x = dma_pool_alloc(a,b,c);
|
|
+ x = dma_pool_zalloc(a,b,c);
|
|
if ((x==NULL) || ...) S
|
|
- memset(x,0,...);
|
|
|
|
@depends on patch@
|
|
expression x;
|
|
expression a,b,c;
|
|
statement S;
|
|
@@
|
|
|
|
- x = pci_pool_alloc(a,b,c);
|
|
+ x = pci_pool_zalloc(a,b,c);
|
|
if ((x==NULL) || ...) S
|
|
- memset(x,0,...);
|
|
|
|
//----------------------------------------------------------
|
|
// For org and report mode
|
|
//----------------------------------------------------------
|
|
|
|
@r depends on org || report@
|
|
expression x;
|
|
expression a,b,c;
|
|
statement S;
|
|
position p;
|
|
@@
|
|
|
|
x = @p\(dma_pool_alloc\|pci_pool_alloc\)(a,b,c);
|
|
if ((x==NULL) || ...) S
|
|
memset(x,0, ...);
|
|
|
|
@script:python depends on org@
|
|
p << r.p;
|
|
x << r.x;
|
|
@@
|
|
|
|
msg="%s" % (x)
|
|
msg_safe=msg.replace("[","@(").replace("]",")")
|
|
coccilib.org.print_todo(p[0], msg_safe)
|
|
|
|
@script:python depends on report@
|
|
p << r.p;
|
|
x << r.x;
|
|
@@
|
|
|
|
msg="WARNING: *_pool_zalloc should be used for %s, instead of *_pool_alloc/memset" % (x)
|
|
coccilib.report.print_report(p[0], msg)
|