Greg Kroah-Hartman
598cf27219
Link: https://lore.kernel.org/r/20260217200002.683975158@linuxfoundation.org Tested-by: Florian Fainelli <florian.fainelli@broadcom.com> Tested-by: Takeshi Ogasawara <takeshi.ogasawara@futuring-girl.com> Tested-by: Peter Schneider <pschneider1968@googlemail.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Salvatore Bonaccorso <carnil@debian.org> Tested-by: Brett A C Sheffield <bacs@librecast.net> Tested-by: Mark Brown <broonie@kernel.org> Tested-by: Luna Jernberg <droidbittin@gmail.com> Tested-by: Ronald Warsow <rwarsow@gmx.de> Tested-by: Justin M. Forbes <jforbes@fedoraproject.org> Tested-by: Ron Economos <re@w6rz.net> Tested-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
56 lines
1.1 KiB
Plaintext
56 lines
1.1 KiB
Plaintext
// SPDX-License-Identifier: GPL-2.0-only
|
|
/// Since commit b37a46683739 ("netdevice: add the case if dev is NULL"),
|
|
/// NULL check before dev_{put, hold} functions is not needed.
|
|
///
|
|
/// Based on ifnullfree.cocci by Fabian Frederick.
|
|
///
|
|
// Copyright: (C) 2022 Ziyang Xuan.
|
|
// Comments: -
|
|
// Options: --no-includes --include-headers
|
|
// Version min: 5.15
|
|
|
|
virtual patch
|
|
virtual org
|
|
virtual report
|
|
virtual context
|
|
|
|
@r2 depends on patch@
|
|
expression E;
|
|
@@
|
|
- if (E != NULL)
|
|
(
|
|
__dev_put(E);
|
|
|
|
|
dev_put(E);
|
|
|
|
|
dev_put_track(E, ...);
|
|
|
|
|
__dev_hold(E);
|
|
|
|
|
dev_hold(E);
|
|
|
|
|
dev_hold_track(E, ...);
|
|
)
|
|
|
|
@r depends on context || report || org @
|
|
expression E;
|
|
position p;
|
|
@@
|
|
|
|
* if (E != NULL)
|
|
* \(__dev_put@p\|dev_put@p\|dev_put_track@p\|__dev_hold@p\|dev_hold@p\|
|
|
* dev_hold_track@p\)(E, ...);
|
|
|
|
@script:python depends on org@
|
|
p << r.p;
|
|
@@
|
|
|
|
cocci.print_main("NULL check before dev_{put, hold} functions is not needed", p)
|
|
|
|
@script:python depends on report@
|
|
p << r.p;
|
|
@@
|
|
|
|
msg = "WARNING: NULL check before dev_{put, hold} functions is not needed."
|
|
coccilib.report.print_report(p[0], msg)
|