Greg Kroah-Hartman
598cf27219
Link: https://lore.kernel.org/r/20260217200002.683975158@linuxfoundation.org Tested-by: Florian Fainelli <florian.fainelli@broadcom.com> Tested-by: Takeshi Ogasawara <takeshi.ogasawara@futuring-girl.com> Tested-by: Peter Schneider <pschneider1968@googlemail.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Salvatore Bonaccorso <carnil@debian.org> Tested-by: Brett A C Sheffield <bacs@librecast.net> Tested-by: Mark Brown <broonie@kernel.org> Tested-by: Luna Jernberg <droidbittin@gmail.com> Tested-by: Ronald Warsow <rwarsow@gmx.de> Tested-by: Justin M. Forbes <jforbes@fedoraproject.org> Tested-by: Ron Economos <re@w6rz.net> Tested-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
55 lines
1.1 KiB
Plaintext
55 lines
1.1 KiB
Plaintext
// SPDX-License-Identifier: GPL-2.0-only
|
|
///
|
|
/// From Documentation/filesystems/sysfs.rst:
|
|
/// show() should only use sysfs_emit() or sysfs_emit_at() when formatting
|
|
/// the value to be returned to user space.
|
|
///
|
|
// Confidence: High
|
|
// Copyright: (C) 2020 Denis Efremov ISPRAS
|
|
// Options: --no-includes --include-headers
|
|
//
|
|
|
|
virtual report
|
|
virtual org
|
|
virtual context
|
|
virtual patch
|
|
|
|
@r depends on !patch@
|
|
identifier show, dev, attr, buf;
|
|
position p;
|
|
@@
|
|
|
|
ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
|
|
{
|
|
<...
|
|
* return snprintf@p(...);
|
|
...>
|
|
}
|
|
|
|
@rp depends on patch@
|
|
identifier show, dev, attr, buf;
|
|
expression BUF, SZ, FORMAT;
|
|
@@
|
|
|
|
ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
|
|
{
|
|
<...
|
|
return
|
|
- snprintf(BUF, SZ, FORMAT
|
|
+ sysfs_emit(BUF, FORMAT
|
|
,...);
|
|
...>
|
|
}
|
|
|
|
@script: python depends on report@
|
|
p << r.p;
|
|
@@
|
|
|
|
coccilib.report.print_report(p[0], "WARNING: please use sysfs_emit or sysfs_emit_at")
|
|
|
|
@script: python depends on org@
|
|
p << r.p;
|
|
@@
|
|
|
|
coccilib.org.print_todo(p[0], "WARNING: please use sysfs_emit or sysfs_emit_at")
|