Greg Kroah-Hartman
598cf27219
Link: https://lore.kernel.org/r/20260217200002.683975158@linuxfoundation.org Tested-by: Florian Fainelli <florian.fainelli@broadcom.com> Tested-by: Takeshi Ogasawara <takeshi.ogasawara@futuring-girl.com> Tested-by: Peter Schneider <pschneider1968@googlemail.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Salvatore Bonaccorso <carnil@debian.org> Tested-by: Brett A C Sheffield <bacs@librecast.net> Tested-by: Mark Brown <broonie@kernel.org> Tested-by: Luna Jernberg <droidbittin@gmail.com> Tested-by: Ronald Warsow <rwarsow@gmx.de> Tested-by: Justin M. Forbes <jforbes@fedoraproject.org> Tested-by: Ron Economos <re@w6rz.net> Tested-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
35 lines
1013 B
Plaintext
35 lines
1013 B
Plaintext
// SPDX-License-Identifier: GPL-2.0-only
|
|
/// Use %pe format specifier instead of PTR_ERR() for printing error pointers.
|
|
///
|
|
/// For printing error pointers (i.e., a pointer for which IS_ERR() is true)
|
|
/// %pe will print a symbolic error name (e.g., -EINVAL), opposed to the raw
|
|
/// errno (e.g., -22) produced by PTR_ERR().
|
|
/// It also makes the code cleaner by saving a redundant call to PTR_ERR().
|
|
///
|
|
// Confidence: High
|
|
// Copyright: (C) 2025 NVIDIA CORPORATION & AFFILIATES.
|
|
// URL: https://coccinelle.gitlabpages.inria.fr/website
|
|
// Options: --no-includes --include-headers
|
|
|
|
virtual context
|
|
virtual org
|
|
virtual report
|
|
|
|
@r@
|
|
expression ptr;
|
|
constant fmt;
|
|
position p;
|
|
identifier print_func;
|
|
@@
|
|
* print_func(..., fmt, ..., PTR_ERR@p(ptr), ...)
|
|
|
|
@script:python depends on r && report@
|
|
p << r.p;
|
|
@@
|
|
coccilib.report.print_report(p[0], "WARNING: Consider using %pe to print PTR_ERR()")
|
|
|
|
@script:python depends on r && org@
|
|
p << r.p;
|
|
@@
|
|
coccilib.org.print_todo(p[0], "WARNING: Consider using %pe to print PTR_ERR()")
|